enhancement: Add ability to attach files to email #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaymckay
requested review from
wass3r,
GregoryDosh,
jbrockopp,
KellyMerrick,
plyr4,
svcvela and
a team
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 18.45% 20.93% +2.47%
==========================================
Files 3 3
Lines 428 449 +21
==========================================
+ Hits 79 94 +15
- Misses 346 353 +7
+ Partials 3 2 -1
|
kaymckay
requested review from
a team
and removed request for
wass3r,
GregoryDosh,
jbrockopp,
KellyMerrick,
plyr4 and
svcvela
wass3r
reviewed
Mar 9, 2022
|
@wass3r this isn't a breaking change, and i'm not sure what you mean by attribution but i pulled it off the internet. I can replace it with a target image if needed |
wass3r
approved these changes
Mar 9, 2022
plyr4
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for go-vela/community#513
adds ability to attach files to an email. This PR corrects the use of email.Attachment and adds EmailFilename to be the file that contains the contents of the email.